Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect transform with async/await (#565) #968

Merged
merged 3 commits into from
Jun 4, 2022

Conversation

PeterBurner
Copy link
Contributor

* Update babel-plugin-transform-async-to-promises to v0.8.18
@changeset-bot
Copy link

changeset-bot bot commented Jun 3, 2022

🦋 Changeset detected

Latest commit: be8c907

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
microbundle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Any idea if this is necessary? Looks like Yarn (v1, anyhow) will correctly resolve the newer version on a fresh install. Not sure if other tools do the same.

Edit: Looks like the snapshots need to be updated. Looks to be a pretty minor & innocent diff, so jest -u should be fine

@rschristian rschristian merged commit 88241dd into developit:master Jun 4, 2022
@preact-bot preact-bot mentioned this pull request Jun 4, 2022
@PeterBurner
Copy link
Contributor Author

Any idea if this is necessary? Looks like Yarn (v1, anyhow) will correctly resolve the newer version on a fresh install. Not sure if other tools do the same.

This might be true. However since the fixed bug in babel-plugin-transform-async-to-promises affects how code is transformed, an update might break things for some users. In my eyes this warrants a new microbundle version. Including a explicit warning in the release notes.

@rschristian
Copy link
Collaborator

an update might break things for some users

If it was breaking (I don't think it is), this should've been marked as a semver minor (as we're still in a 0-major), not a patch. But as microbundle used ^0.8.15, lock file permitting, this update could've happened at any point. It's not locked behind a new version.

Fair enough if that was the justification, a new microbundle version will force users to get this fix I suppose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect transform with async/await
2 participants